Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Base RFQ Time #2403

Merged
merged 1 commit into from
Mar 29, 2024
Merged

SDK Base RFQ Time #2403

merged 1 commit into from
Mar 29, 2024

Conversation

aureliusbtc
Copy link
Contributor

@aureliusbtc aureliusbtc commented Mar 29, 2024

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Summary by CodeRabbit

  • New Features
    • Introduced a new constant for median time requests on the BASE chain, enhancing the SDK's routing capabilities.

Copy link
Contributor

coderabbitai bot commented Mar 29, 2024

Walkthrough

This update introduces a new constant MEDIAN_TIME_RFQ specifically for SupportedChainId.BASE, setting its value to 15. This change reflects an adjustment in the median time request for quotation (RFQ) settings, optimizing the performance or functionality within the SDK router package.

Changes

File Path Change Summary
packages/sdk-router/src/constants/medianTime.ts Added MEDIAN_TIME_RFQ for SupportedChainId.BASE set to 15

🐰✨
In the land of code, where the bits do roam,
A new constant springs, in its digital home.
MEDIAN_TIME_RFQ, so sleek and so neat,
Set to fifteen, it's quite the feat.
Hop, hop, hooray, let's celebrate,
For efficiency’s gain, we appreciate!
🌟🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@aureliusbtc aureliusbtc merged commit 5b276ab into master Mar 29, 2024
16 of 18 checks passed
@aureliusbtc aureliusbtc deleted the base/rfq-time branch March 29, 2024 23:54
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between ae858ad and 186ad05.
Files selected for processing (1)
  • packages/sdk-router/src/constants/medianTime.ts (1 hunks)
Additional Context Used
Additional comments not posted (1)
packages/sdk-router/src/constants/medianTime.ts (1)

52-52: The addition of [SupportedChainId.BASE]: 15 to MEDIAN_TIME_RFQ aligns with the PR's objectives and maintains consistency with the structure of existing constants. However, ensure that the value of 15 seconds is appropriate and consistent with the median times for RFQ transactions across other supported chains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant