-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK Base RFQ Time #2403
SDK Base RFQ Time #2403
Conversation
WalkthroughThis update introduces a new constant Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- packages/sdk-router/src/constants/medianTime.ts (1 hunks)
Additional Context Used
Additional comments not posted (1)
packages/sdk-router/src/constants/medianTime.ts (1)
52-52
: The addition of[SupportedChainId.BASE]: 15
toMEDIAN_TIME_RFQ
aligns with the PR's objectives and maintains consistency with the structure of existing constants. However, ensure that the value of 15 seconds is appropriate and consistent with the median times for RFQ transactions across other supported chains.
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit