Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synapse-interface): remove blast swap pause banner #2381

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Mar 27, 2024

Summary by CodeRabbit

  • Refactor
    • Updated the visual presentation by removing the AnnouncementBanner component related to swapping being paused on Blast.

076f40d00bdfb05eaee56669e95abc275ca9b2e4: synapse-interface preview link
048177591fef0d0c6788292a8fe7a27db33d6f22: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Mar 27, 2024

Walkthrough

The recent update involves removing the AnnouncementBanner component from a specific page, impacting the visual presentation of the StateManagedSwap component. This change streamlines the swap interface by eliminating the pause announcement previously displayed on Blast.

Changes

File Path Change Summary
.../swap/index.tsx Removed AnnouncementBanner, refining UI for swaps

🐰🎩
In the realm of code, where changes take flight,
The banner vanished, ushering in a new light.
Swaps now unfettered, no pause to impede,
A rabbit dances, for simplicity decreed.
Farewell to the banner, let the swap flow with speed!
🚀🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.88667%. Comparing base (0aedf05) to head (2685456).

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #2381   +/-   ##
=============================================
  Coverage   46.88667%   46.88667%           
=============================================
  Files            383         383           
  Lines          29181       29181           
  Branches          83          83           
=============================================
  Hits           13682       13682           
  Misses         14041       14041           
  Partials        1458        1458           
Flag Coverage Δ
packages 90.52734% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 0aedf05 and a6547eb.
Files selected for processing (1)
  • packages/synapse-interface/pages/swap/index.tsx (1 hunks)

Copy link

cloudflare-workers-and-pages bot commented Mar 27, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2685456
Status: ✅  Deploy successful!
Preview URL: https://59e130c6.sanguine-fe.pages.dev
Branch Preview URL: https://fe-remove-swap-blast-banner.sanguine-fe.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Mar 27, 2024

Deploying sanguine with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2685456
Status: ✅  Deploy successful!
Preview URL: https://d67436a9.sanguine.pages.dev
Branch Preview URL: https://fe-remove-swap-blast-banner.sanguine.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between a6547eb and 2685456.
Files selected for processing (1)
  • packages/synapse-interface/pages/swap/index.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/synapse-interface/pages/swap/index.tsx

@bigboydiamonds bigboydiamonds merged commit c49c60d into master Mar 27, 2024
42 checks passed
@bigboydiamonds bigboydiamonds deleted the fe/remove-swap-blast-banner branch March 27, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants