-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(synapse-interface): adds ETH to RFQ for rebates #2351
Conversation
WalkthroughThe recent update introduces a nuanced eligibility condition for RFQ (Request for Quote) transactions within a financial application's interface. Specifically, it now considers a token's route symbol being 'ETH' alongside its swapable type 'USD' as criteria for RFQ eligibility. This change enhances the application's transaction routing logic, allowing for more precise and diversified trading strategies. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- packages/synapse-interface/utils/hooks/useStipEligibility.ts (1 hunks)
Additional comments: 1
packages/synapse-interface/utils/hooks/useStipEligibility.ts (1)
- 239-242: The addition of
token.routeSymbol === 'ETH'
to the eligibility criteria for RFQ rebates is a significant enhancement that aligns with the PR objectives. This change effectively broadens the scope of transactions eligible for rebates, potentially increasing user engagement with Ethereum-based transactions.However, it's recommended to conduct thorough testing, especially focusing on performance implications and ensuring that this new condition integrates seamlessly with existing logic without introducing unintended side effects.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2351 +/- ##
===================================================
+ Coverage 46.97743% 47.13743% +0.16000%
===================================================
Files 373 361 -12
Lines 28618 27388 -1230
Branches 83 83
===================================================
- Hits 13444 12910 -534
+ Misses 13764 13135 -629
+ Partials 1410 1343 -67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying sanguine-fe with Cloudflare Pages
|
Deploying sanguine with Cloudflare Pages
|
Summary by CodeRabbit
8a329c133a31bc89e0432fea03024d12d2322864: synapse-interface preview link