-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App abstraction (go changes) #2349
Changes from 3 commits
33b9333
f0a1c35
7eb800e
c5cd43d
02cd2a9
4a14231
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
package executionfeesmock | ||
|
||
//go:generate go run github.com/synapsecns/sanguine/tools/abigen generate --sol ../../../../packages/contracts-communication/flattened/ExecutionfeesMock.sol --pkg executionfeesmock --sol-version 0.8.20 --filename executionfeesmock --evm-version istanbul | ||
//go:generate go run github.com/synapsecns/sanguine/tools/abigen generate --sol ../../../../packages/contracts-communication/flattened/ExecutionFeesMock.sol --pkg executionfeesmock --sol-version 0.8.20 --filename executionfeesmock --evm-version istanbul |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
package interchainapp | ||
|
||
//go:generate go run github.com/synapsecns/sanguine/tools/abigen generate --sol ../../../../packages/contracts-communication/flattened/InterchainAppExample.sol --pkg interchainapp --sol-version 0.8.20 --filename interchainapp --evm-version istanbul | ||
//go:generate go run github.com/synapsecns/sanguine/tools/abigen generate --sol ../../../../packages/contracts-communication/flattened/ExampleAppV1.sol --pkg interchainapp --sol-version 0.8.20 --filename interchainapp --evm-version istanbul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming
InterchainAppMockRef
toMockRef
to avoid stuttering in the package name usage, as suggested by Go conventions.Committable suggestion