Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App abstraction (go changes) #2349

Merged
merged 6 commits into from
Mar 22, 2024
Merged

App abstraction (go changes) #2349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
33b9333
Update `generate.go`
ChiTimesChi Mar 21, 2024
f0a1c35
Regenerate `sin-executor`
ChiTimesChi Mar 21, 2024
7eb800e
Update Example App references
ChiTimesChi Mar 21, 2024
c5cd43d
Use non-zero period in tests
ChiTimesChi Mar 22, 2024
02cd2a9
Use `GetMessageFee` for setting the message value
ChiTimesChi Mar 22, 2024
4a14231
Use non-zero gas airdrop amount in tests
ChiTimesChi Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sin-executor/contracts/executionservice/executionservice.abigen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sin-executor/contracts/executionservice/executionservice.contractinfo.json
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions sin-executor/contracts/interchainclient/interchainclient.abigen.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion sin-executor/contracts/interchainclient/interchainclient.contractinfo.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion sin-executor/contracts/mocks/executionfeesmock/executionfeesmock.abigen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sin-executor/contracts/mocks/executionfeesmock/executionfeesmock.contractinfo.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion sin-executor/contracts/mocks/executionfeesmock/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package executionfeesmock

//go:generate go run github.com/synapsecns/sanguine/tools/abigen generate --sol ../../../../packages/contracts-communication/flattened/ExecutionfeesMock.sol --pkg executionfeesmock --sol-version 0.8.20 --filename executionfeesmock --evm-version istanbul
//go:generate go run github.com/synapsecns/sanguine/tools/abigen generate --sol ../../../../packages/contracts-communication/flattened/ExecutionFeesMock.sol --pkg executionfeesmock --sol-version 0.8.20 --filename executionfeesmock --evm-version istanbul
2 changes: 1 addition & 1 deletion sin-executor/contracts/mocks/interchainapp/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package interchainapp

//go:generate go run github.com/synapsecns/sanguine/tools/abigen generate --sol ../../../../packages/contracts-communication/flattened/InterchainAppExample.sol --pkg interchainapp --sol-version 0.8.20 --filename interchainapp --evm-version istanbul
//go:generate go run github.com/synapsecns/sanguine/tools/abigen generate --sol ../../../../packages/contracts-communication/flattened/ExampleAppV1.sol --pkg interchainapp --sol-version 0.8.20 --filename interchainapp --evm-version istanbul
8 changes: 4 additions & 4 deletions sin-executor/contracts/mocks/interchainapp/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (

// InterchainAppMockRef is a reference to an interchain db.
type InterchainAppMockRef struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming InterchainAppMockRef to MockRef to avoid stuttering in the package name usage, as suggested by Go conventions.

- type InterchainAppMockRef struct {
+ type MockRef struct {
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
type InterchainAppMockRef struct {
type MockRef struct {

*InterchainAppExample
*ExampleAppV1
// address of the interchain client
address common.Address
}
Expand All @@ -22,13 +22,13 @@ func (i *InterchainAppMockRef) Address() common.Address {

// NewInterchainAppRef creates a new interchain client with a contract ref.
func NewInterchainAppRef(address common.Address, backend bind.ContractBackend) (*InterchainAppMockRef, error) {
instance, err := NewInterchainAppExample(address, backend)
instance, err := NewExampleAppV1(address, backend)
if err != nil {
return nil, fmt.Errorf("could not create instance of InterchainClient: %w", err)
}
return &InterchainAppMockRef{
InterchainAppExample: instance,
address: address,
ExampleAppV1: instance,
address: address,
}, nil
}

Expand Down
Loading
Loading