-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE Release 3-21 #2341
FE Release 3-21 #2341
Changes from 17 commits
ae35454
1fd2528
b9b84a2
ff5a135
3312b99
2b8a743
d652041
e8f1a8d
579da27
e56d316
18594bb
383ee4e
1eb8000
8f6a1b5
d09c032
8f2966e
7bfb6a1
fd770ad
018c0d9
748a433
ddabd69
198dc48
8c9f382
1e0c559
b1df384
fe868cc
0e6d76c
8a82589
b0836c9
970d5a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,6 +98,7 @@ export class FastBridgeRouter implements SynapseModule { | |
* @inheritdoc SynapseModule.getSynapseTxId | ||
*/ | ||
public async getSynapseTxId(txHash: string): Promise<string> { | ||
// TODO: this should support older instances of FastBridge to track legacy txs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment regarding supporting older instances of FastBridge for tracking legacy transactions is clear and appropriately placed. Consider creating a tracking issue for this TODO item to ensure it's addressed in future updates. Would you like me to open a GitHub issue to track this task? |
||
const fastBridgeContract = await this.getFastBridgeContract() | ||
const fastBridgeLog = await getMatchingTxLog( | ||
this.provider, | ||
|
@@ -114,6 +115,7 @@ export class FastBridgeRouter implements SynapseModule { | |
* @inheritdoc SynapseModule.getBridgeTxStatus | ||
*/ | ||
public async getBridgeTxStatus(synapseTxId: string): Promise<boolean> { | ||
// TODO: this should support older instances of FastBridge to track legacy txs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment about supporting older instances of FastBridge for tracking legacy transactions is consistent and clear. Consider creating a tracking issue for this TODO item to ensure it's addressed in future updates. Would you like me to open a GitHub issue to track this task? |
||
const fastBridgeContract = await this.getFastBridgeContract() | ||
return fastBridgeContract.bridgeRelays(synapseTxId) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
TODO
comment to reinstate lint is a good reminder for future improvements. Ensure this task is tracked appropriately.Would you like me to open a GitHub issue to track the reinstatement of lint checks?