-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Metis #2322
Extend Metis #2322
Conversation
WalkthroughThe recent updates involve adjustments to the timing logic within a user interface component and a modification to the schedule of an event named "Ecotone Fork Upgrade." Specifically, the way hours are rounded in a countdown component has been altered, and the start and end times of the Ecotone Fork event have been shifted later by two and three hours respectively. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- packages/synapse-interface/components/Maintenance/EventCountdownProgressBar.tsx (1 hunks)
- packages/synapse-interface/components/Maintenance/Events/example/EcotoneForkUpgrade.tsx (1 hunks)
Additional comments: 2
packages/synapse-interface/components/Maintenance/Events/example/EcotoneForkUpgrade.tsx (1)
- 24-25: The changes to
ECOTONE_FORK_START_DATE
andECOTONE_FORK_END_DATE
align with the PR's objective to adjust event timing. Ensure that any dependent components or systems that rely on these constants are also updated to reflect the new event times.packages/synapse-interface/components/Maintenance/EventCountdownProgressBar.tsx (1)
- 146-146: Changing the rounding logic for
hoursRemaining
fromMath.floor
toMath.ceil
in thecalculateTimeUntilTarget
function is a sensible adjustment for improving the accuracy of event countdowns. This change ensures that even a fractional hour remaining is counted as a full hour, which aligns with the PR's objective to enhance the user experience of event countdowns.
Summary by CodeRabbit
5081dabe0de1e172dcabfabbbbfd53820807b020: synapse-interface preview link