Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Metis #2322

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Extend Metis #2322

merged 1 commit into from
Mar 20, 2024

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Mar 20, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Improved accuracy in countdown display for upcoming events by adjusting the rounding logic for hours remaining.
  • New Features
    • Updated the start and end times for the Ecotone Fork Upgrade event to reflect new scheduling.

5081dabe0de1e172dcabfabbbbfd53820807b020: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Mar 20, 2024

Walkthrough

The recent updates involve adjustments to the timing logic within a user interface component and a modification to the schedule of an event named "Ecotone Fork Upgrade." Specifically, the way hours are rounded in a countdown component has been altered, and the start and end times of the Ecotone Fork event have been shifted later by two and three hours respectively.

Changes

Files Change Summary
.../EventCountdownProgressBar.tsx Changed hoursRemaining calculation from Math.floor to Math.ceil.
.../Events/example/EcotoneForkUpgrade.tsx Adjusted ECOTONE_FORK_START_DATE from 16:00 to 18:00 UTC and ECOTONE_FORK_END_DATE from 18:00 to 21:00 UTC.

🐰✨
In the lands of code, where changes abound,
A rabbit hopped, leaving marks on the ground.
"Tick tock," it said, "let's round up, not down,
And shift our event, with no need to frown."
For in each update, a chance to enhance,
With every hop, a new dance.
🌟🕒🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@abtestingalpha abtestingalpha merged commit 95aeb24 into master Mar 20, 2024
37 of 39 checks passed
@abtestingalpha abtestingalpha deleted the fe/metis-longer branch March 20, 2024 18:16
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 9a24718 and f9c4c93.
Files selected for processing (2)
  • packages/synapse-interface/components/Maintenance/EventCountdownProgressBar.tsx (1 hunks)
  • packages/synapse-interface/components/Maintenance/Events/example/EcotoneForkUpgrade.tsx (1 hunks)
Additional comments: 2
packages/synapse-interface/components/Maintenance/Events/example/EcotoneForkUpgrade.tsx (1)
  • 24-25: The changes to ECOTONE_FORK_START_DATE and ECOTONE_FORK_END_DATE align with the PR's objective to adjust event timing. Ensure that any dependent components or systems that rely on these constants are also updated to reflect the new event times.
packages/synapse-interface/components/Maintenance/EventCountdownProgressBar.tsx (1)
  • 146-146: Changing the rounding logic for hoursRemaining from Math.floor to Math.ceil in the calculateTimeUntilTarget function is a sensible adjustment for improving the accuracy of event countdowns. This change ensures that even a fractional hour remaining is counted as a full hour, which aligns with the PR's objective to enhance the user experience of event countdowns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant