Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resetting synapse-constants bridge map for canto eth #2299

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Defi-Moses
Copy link
Collaborator

@Defi-Moses Defi-Moses commented Mar 14, 2024

Edits the synapse-constants package to remove canto ETH from bridgeMap.

Summary by CodeRabbit

  • Chores
    • Updated the synapse-constants package version to 1.3.5.
  • Refactor
    • Removed an entry from the BRIDGE_MAP and updated the swappable field for another entry to enhance data accuracy.

@Defi-Moses Defi-Moses requested review from abtestingalpha and aureliusbtc and removed request for trajan0x March 14, 2024 19:19
Copy link
Contributor

coderabbitai bot commented Mar 14, 2024

Walkthrough

The update primarily involves modifications to the blockchain bridge configurations within the synapse-constants package. An entry was removed from the bridge map, indicating a bridge is no longer swappable or perhaps deprecated. Additionally, another entry's swappability was disabled by setting its swappable field to an empty array. The package version was bumped to reflect these changes.

Changes

Files Change Summary
.../constants/bridgeMap.ts & .../constants/tokens/bridgeMap.ts Removed entry '0x5FD55A1B9FC24967C4dB09C513C3BA0DFa7FF687' and updated '0x4e71A2E537B7f9D9413D3991D37958c0b5e1e503' swappable to []
.../package.json Version updated from "1.3.3" to "1.3.5"

🐰✨
Changes in the code, as swift as can be,
Bridges once crossed, now we set free.
From 1.3.3 to 1.3.5, we hop,
In the world of code, we never stop.
Through fields of data, under the tech tree,
We make our mark, for all to see. 🌟
🐰💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1433f1c
Status: ✅  Deploy successful!
Preview URL: https://755fd2bd.sanguine-fe.pages.dev
Branch Preview URL: https://feat-constants-canto-upgrade.sanguine-fe.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 8fe49ec and 1433f1c.
Files selected for processing (3)
  • packages/synapse-constants/constants/bridgeMap.ts (2 hunks)
  • packages/synapse-constants/constants/tokens/bridgeMap.ts (2 hunks)
  • packages/synapse-constants/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/synapse-constants/package.json
Additional comments: 3
packages/synapse-constants/constants/bridgeMap.ts (1)
  • 1028-1028: The adjustment to the swappable field for the entry '0x4e71A2E537B7f9D9413D3991D37958c0b5e1e503' aligns with the PR objectives. This modification correctly updates the swappability options for this entry.
packages/synapse-constants/constants/tokens/bridgeMap.ts (2)
  • 1025-1031: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-1028]

The removal of the canto ETH entry identified by '0x5FD55A1B9FC24967C4dB09C513C3BA0DFa7FF687' has been successfully executed, aligning with the PR objectives.

  • 1028-1028: The update to the swappable field for the entry identified by '0x4e71A2E537B7f9D9413D3991D37958c0b5e1e503' to an empty array has been successfully executed, aligning with the PR objectives.

@aureliusbtc aureliusbtc merged commit 096185c into master Mar 15, 2024
32 of 34 checks passed
@aureliusbtc aureliusbtc deleted the feat/constants-canto-upgrade branch March 15, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants