fix(synapse-interface): deprecate unused dependencies #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move deps that are for development into devDeps * Remove unused deps * Remove deprecated code
abtestingalpha
requested review from
bigboydiamonds,
aureliusbtc and
trajan0x
as code owners
WalkthroughThe project has undergone a significant transformation, focusing on dependency management and code optimization. Key changes include transitioning from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://github.com/avatars/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (6)
- packages/synapse-interface/components/StateManagedBridge/BridgeTransactionButton.tsx (1 hunks)
- packages/synapse-interface/package.json (4 hunks)
- packages/synapse-interface/pages/pool/poolManagement/Deposit.tsx (3 hunks)
- packages/synapse-interface/pages/state-managed-bridge/index.tsx (1 hunks)
- packages/synapse-interface/utils/types/index.tsx (1 hunks)
- yarn.lock (15 hunks)
Files skipped from review due to trivial changes (1)
- packages/synapse-interface/package.json
Additional comments: 4
packages/synapse-interface/components/StateManagedBridge/BridgeTransactionButton.tsx (1)
- 8-8: The import of
isAddresshas been successfully updated from@ethersproject/addresstoviem. Please ensure that the functionality ofisAddressfromviemmatches the expected behavior and that all instances whereisAddressis used have been tested to confirm correct operation.packages/synapse-interface/utils/types/index.tsx (1)
- 3-3: The import of
getAddresshas been successfully updated from@ethersproject/addresstoviem. Please ensure that the functionality ofgetAddressfromviemmatches the expected behavior and that all instances wheregetAddressis used have been tested to confirm correct operation.packages/synapse-interface/pages/pool/poolManagement/Deposit.tsx (1)
- 43-43: The import of
getAddressandzeroAddresshas been successfully updated to usevieminstead of@ethersproject/address. Please ensure that the functionality of these functions fromviemmatches the expected behavior and that all instances where they are used have been tested to confirm correct operation.packages/synapse-interface/pages/state-managed-bridge/index.tsx (1)
- 64-64: The import of
isAddresshas been successfully updated to useviem, and the removal ofcreatePublicClientandhttpimports suggests a cleanup of unused imports. Please ensure that the functionality ofisAddressfromviemmatches the expected behavior and that all instances where it is used have been tested to confirm correct operation. Additionally, confirm that the removal ofcreatePublicClientandhttpdoes not affect any functionality.
Deploying with
|
| Latest commit: |
c043f28
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9c0ce9df.sanguine.pages.dev |
| Branch Preview URL: | https://fe-shuffle-deps.sanguine.pages.dev |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- packages/synapse-interface/package.json (4 hunks)
- yarn.lock (17 hunks)
Files skipped from review as they are similar to previous changes (1)
- yarn.lock
Additional comments: 1
packages/synapse-interface/package.json (1)
- 99-107: The addition of testing-related dependencies (
cypress,@depay/web3-mock,@testing-library/cypress,start-server-and-test,@graphql-codegen/cli,@graphql-codegen/client-preset,@graphql-codegen/introspection,@graphql-codegen/typescript-rtk-query,@testing-library/jest-dom,@testing-library/react,@types/redux-persist,jest,jest-environment-jsdom) is a positive change, enhancing the project's testing capabilities. However, ensure that the newly added dependencies are indeed used within the project's tests to avoid bloating thedevDependencies. If some of these packages are not utilized, consider removing them to keep the project lean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
044f370ab4472dfb774d93b5fc21e1e3e8adedfe: synapse-interface preview link
da8090ad090f19e7b91d2a3f5df311bd13c1f9b5: synapse-interface preview link
6e6fb45e27395aeb8ba6f36db84f4f61de0ceb06: synapse-interface preview link
6d55f9483ff30cb035b5f0d4196458510ae639ff: synapse-interface preview link