Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade goreleaser to support go 1.22 #2200

Merged
merged 2 commits into from
Mar 4, 2024
Merged

upgrade goreleaser to support go 1.22 #2200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0ca24d
deprecate explorer [goreleaser]
trajan0x Mar 4, 2024
7d33c55
sha256 sum [goreleaser]
trajan0x Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ root
├── <a href="./merkle">merkle</a>: Provides a go based merkle tree implementation.
├── <a href="./metrics">metrics</a>: Provides a set of utilities for working with metrics/otel tracing.
├── <a href="./mocktesting">mocktesting</a>: Provides a mocked tester for use with `testing.TB`
├── <a href="./observer">observer</a>: Provides an interface for adding/removing listeners.
├── <a href="./observer"><s>observer</s></a>(deprecated): Provides an interface for adding/removing listeners.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation of the observer module is clearly marked. However, it would be beneficial for users if additional information were provided regarding the reason for deprecation and any recommended alternatives or migration paths.

├── <a href="./processlog">processlog</a>: Provides a way to interact with detatched processes as streams.
├── <a href="./retry">retry</a>: Retries a function until it succeeds or the timeout is reached. This comes with a set of backoff strategies/options.
├── <a href="./server">server</a>: Provides a context-safe server that can be used to start/stop a server.
Expand Down
8 changes: 4 additions & 4 deletions docker/goreleaser/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM --platform=linux/amd64 debian:11

ARG VERSION_ARG=1.20.0-pro
ARG SHA_ARG=d2d76cf4b212f67cb9995c8539167a1c6d771859aad20ed242bfab640b6d396f
ARG VERSION_ARG=1.24.0-pro
ARG SHA_ARG=4723a3063febbbdafd345e9c877f095dfc9c8a467b0eefe1987354aa1860970f
ARG FILE_ARG=goreleaser-pro_Linux_x86_64.tar.gz
ARG DOWNLOAD_ARG=https://github.com/goreleaser/goreleaser-pro/releases/download/v${VERSION_ARG}/${FILE_ARG}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [33-33]

The TODO comment indicates that SHA checksum verification for the yq binary download is missing. Implementing this verification is crucial for ensuring the security of the build process by preventing tampering or compromise.

Expand All @@ -12,8 +12,8 @@ ENV GORELEASER_DOWNLOAD_FILE=$FILE_ARG
ENV GORELEASER_DOWNLOAD_URL=$DOWNLOAD_ARG

# Golang
ENV GOLANG_VERSION=1.21.3
ENV GOLANG_SHA=1241381b2843fae5a9707eec1f8fb2ef94d827990582c7c7c32f5bdfbfd420c8
ENV GOLANG_VERSION=1.22.0
ENV GOLANG_SHA=f6c8a87aa03b92c4b0bf3d558e28ea03006eb29db78917daec5cfb6ec1046265
ENV GOLANG_DOWNLOAD_FILE=go${GOLANG_VERSION}.linux-amd64.tar.gz
ENV GOLANG_DOWNLOAD_URL=https://dl.google.com/go/${GOLANG_DOWNLOAD_FILE}

Expand Down
Loading