Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fraud Report Final Touches 🎉 #1339

Merged
merged 16 commits into from
Sep 12, 2023
Merged

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Sep 9, 2023

Description

Tracking in: #1280 (comment)

@github-actions github-actions bot added M-ci Module: CI size/xs labels Sep 9, 2023
trajan0x added a commit that referenced this pull request Sep 9, 2023
trajan0x added a commit that referenced this pull request Sep 10, 2023
Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/fraud-reports@6031092). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feat/fraud-reports       #1339   +/-   ##
========================================================
  Coverage                      ?   48.24479%           
========================================================
  Files                         ?         278           
  Lines                         ?       22305           
  Branches                      ?           0           
========================================================
  Hits                          ?       10761           
  Misses                        ?       10366           
  Partials                      ?        1178           
Flag Coverage Δ
cctp-relayer 63.33333% <0.00000%> (?)
core 58.76250% <0.00000%> (?)
explorer 24.92882% <0.00000%> (?)
git-changes-action 53.94265% <0.00000%> (?)
omnirpc 53.19635% <0.00000%> (?)
promexporter 41.02564% <0.00000%> (?)
release-copier-action 19.33333% <0.00000%> (?)
scribe 51.47151% <0.00000%> (?)
tools 21.72452% <0.00000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trajan0x trajan0x marked this pull request as ready for review September 10, 2023 19:11
- name: Test
uses: nick-fields/retry@v2
with:
command: |
set -e
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation: Why the Script Didn't Stop on Errors

The provided script looped through each package and ran a series of commands on each package. If any command failed during this process, the script would simply continue to the next package in the list without stopping.

This behavior is due to the default nature of bash scripting. By default, a bash script won't terminate or exit just because a command inside it fails. Instead, it will continue executing subsequent commands.

If you want a bash script to exit immediately when a command fails, you need to add the set -e directive at the beginning of the script. The set -e directive instructs the shell to exit immediately if any command in the script returns a non-zero exit status (indicating failure).

Without the set -e directive, your script will continue running subsequent commands even if one of them fails, which is the behavior you observed.

@trajan0x trajan0x mentioned this pull request Sep 10, 2023
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 10, 2023
@dwasse dwasse merged commit dba250c into feat/fraud-reports Sep 12, 2023
55 of 57 checks passed
@dwasse dwasse deleted the feat/fast-fraud-reports branch September 12, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code M-ci Module: CI size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants