Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes slippage percentage #1296

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Fixes slippage percentage #1296

merged 2 commits into from
Aug 31, 2023

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Aug 31, 2023

  • Fixes off by 100 error on percentage
  • Renames as SwapExchangeRateInfo, deprecates unused code

84e61f837408a6b16465c5d9741744e682038c3c: synapse-interface preview link

@abtestingalpha abtestingalpha changed the title Fixes slippage info Fixes slippage percentage Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15680% ⚠️

Comparison is base (d62658c) 60.30048% compared to head (f9d5f9a) 60.14368%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1296         +/-   ##
===================================================
- Coverage   60.30048%   60.14368%   -0.15680%     
===================================================
  Files            566         534         -32     
  Lines          34212       32991       -1221     
  Branches         277         277                 
===================================================
- Hits           20630       19842        -788     
+ Misses         11710       11362        -348     
+ Partials        1872        1787         -85     
Flag Coverage Δ
cctp-relayer ?
packages 83.42541% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ChiTimesChi ChiTimesChi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abtestingalpha abtestingalpha merged commit dffa20a into master Aug 31, 2023
42 checks passed
@abtestingalpha abtestingalpha deleted the fix/bigIntPercentage branch August 31, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants