Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make core/retry defaults more sane #1275

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Aug 23, 2023

Description

Fixes behavior issues found in #1274, blocked by #176

@github-actions github-actions bot added go Pull requests that update Go code size/s labels Aug 23, 2023
This reverts commit 60dd2b7.
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 92.30769% and project coverage change: -0.18537% ⚠️

Comparison is base (f3d0a58) 60.23570% compared to head (1cfa68b) 60.05033%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1275         +/-   ##
===================================================
- Coverage   60.23570%   60.05033%   -0.18537%     
===================================================
  Files            564         536         -28     
  Lines          34111       32984       -1127     
  Branches         276         276                 
===================================================
- Hits           20547       19807        -740     
+ Misses         11703       11397        -306     
+ Partials        1861        1780         -81     
Flag Coverage Δ
cctp-relayer ?
core 64.64857% <96.00000%> (+0.02296%) ⬆️
ethergo 63.61224% <ø> (+0.07804%) ⬆️
git-changes-action 60.74313% <ø> (ø)
promexporter 41.02564% <ø> (?)
release-copier-action 19.33333% <ø> (ø)
tools 21.72452% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rvices/explorer/consumer/parser/tokendata/cache.go 44.66667% <ø> (ø)
...rvices/explorer/consumer/parser/tokenpool/cache.go 15.55556% <0.00000%> (ø)
core/retry/retry.go 98.85057% <96.00000%> (+1.66747%) ⬆️

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trajan0x trajan0x marked this pull request as ready for review August 23, 2023 16:33
@trajan0x trajan0x merged commit fc6fefd into master Aug 23, 2023
61 checks passed
@trajan0x trajan0x deleted the feat/retry-sane-defaults branch August 23, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant