Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 2 vulnerabilities #1249

Closed
wants to merge 1 commit into from

Conversation

trajan0x
Copy link
Contributor

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • packages/contracts-core/package.json
    • packages/contracts-core/yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 551/1000
Why? Recently disclosed, Has a fix available, CVSS 5.3
Improper Encoding or Escaping of Output
SNYK-JS-OPENZEPPELINCONTRACTS-5838352
No No Known Exploit
medium severity 551/1000
Why? Recently disclosed, Has a fix available, CVSS 5.3
Improper Encoding or Escaping of Output
SNYK-JS-OPENZEPPELINCONTRACTSUPGRADEABLE-5838353
No No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (77e98d0) 59.73222% compared to head (5caa2fe) 59.73222%.

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #1249   +/-   ##
=============================================
  Coverage   59.73222%   59.73222%           
=============================================
  Files            532         532           
  Lines          32937       32937           
  Branches         276         276           
=============================================
  Hits           19674       19674           
  Misses         11503       11503           
  Partials        1760        1760           
Flag Coverage Δ
packages 82.84133% <ø> (ø)
solidity 93.00244% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliusbtc
Copy link
Contributor

Should not be merged until @ChiTimesChi reviews how package upgrade impacts the contracts

@trajan0x trajan0x closed this Aug 17, 2023
@trajan0x trajan0x deleted the snyk-fix-5efa3fdbb2f85d6a7d2372d44b74b6ea branch August 17, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants