Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds zkEVM [sdk] #1226

Closed
wants to merge 3 commits into from
Closed

Adds zkEVM [sdk] #1226

wants to merge 3 commits into from

Conversation

abtestingalpha
Copy link
Collaborator

  • Adds zkEVM chainId and router addresses to constants

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00000% and project coverage change: -0.71895% ⚠️

Comparison is base (265e17e) 59.73222% compared to head (2bd79f4) 59.01327%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1226         +/-   ##
===================================================
- Coverage   59.73222%   59.01327%   -0.71895%     
===================================================
  Files            532         533          +1     
  Lines          32937       32025        -912     
  Branches         276         276                 
===================================================
- Hits           19674       18899        -775     
+ Misses         11503       11430         -73     
+ Partials        1760        1696         -64     
Flag Coverage Δ
packages 82.87293% <100.00000%> (+0.03159%) ⬆️
solidity 93.00244% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/sdk-router/src/constants/index.ts 100.00000% <100.00000%> (ø)

... and 75 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abtestingalpha abtestingalpha marked this pull request as draft August 2, 2023 20:03
@abtestingalpha abtestingalpha changed the title Adds zkEVM Adds zkEVM [sdk] Aug 3, 2023
@github-actions
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 29, 2023
@github-actions github-actions bot closed this Sep 4, 2023
@github-actions github-actions bot deleted the feat/sdk/add-zkevm branch November 16, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant