Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Base chainId & router address to sdk #1205

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Conversation

abtestingalpha
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00000% and project coverage change: +0.00383% 🎉

Comparison is base (67d6ef5) 58.87795% compared to head (472c4a1) 58.88178%.
Report is 10 commits behind head on master.

❗ Current head 472c4a1 differs from pull request most recent head a8b09ad. Consider uploading reports for the commit a8b09ad to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1205         +/-   ##
===================================================
+ Coverage   58.87795%   58.88178%   +0.00383%     
===================================================
  Files            532         532                 
  Lines          32209       32212          +3     
  Branches         275         276          +1     
===================================================
+ Hits           18964       18967          +3     
  Misses         11545       11545                 
  Partials        1700        1700                 
Flag Coverage Δ
packages 82.64925% <100.00000%> (+0.09765%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/sdk-router/src/constants/index.ts 100.00000% <100.00000%> (ø)
packages/sdk-router/src/sdk.ts 85.20408% <100.00000%> (+0.15252%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abtestingalpha abtestingalpha changed the title Adds Base chainId & router address Adds Base chainId & router address to sdk Aug 1, 2023
…ement to handle diff base address to frontend add liquidity calculation
@aureliusbtc aureliusbtc merged commit 779c177 into master Aug 2, 2023
34 checks passed
@aureliusbtc aureliusbtc deleted the sdk/adds-base branch August 2, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants