Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prettier-related dependencies in contracts-core #754

Closed
ChiTimesChi opened this issue Apr 1, 2023 · 0 comments · Fixed by #2338
Closed

Remove prettier-related dependencies in contracts-core #754

ChiTimesChi opened this issue Apr 1, 2023 · 0 comments · Fixed by #2338
Assignees
@ChiTimesChi
Labels
dependencies

Comments

@ChiTimesChi
Copy link
Collaborator

#753 replaced prettier with forge fmt.

The dependencies were not removed in order to avoid merge conflicts, when the branch is eventually going to be merged into master.

However, once #654 is merged, the dependencies could be safely removed.
@ChiTimesChi ChiTimesChi self-assigned this Apr 1, 2023
trajan0x added a commit that referenced this issue Mar 21, 2024
@trajan0x
resolve #754
43ac77e
@trajan0x trajan0x mentioned this issue Mar 21, 2024
Merged
trajan0x added a commit that referenced this issue Mar 21, 2024
@trajan0x
resolve #754 (#2338)
18594bb 
Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
@trajan0x trajan0x mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChiTimesChi ChiTimesChi

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove prettier from contracts-core synapsecns/sanguine
1 participant
@ChiTimesChi