Apply Rabbit suggestions

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
synapsecns · Apr 3, 2024 · 995381b · 995381b
1 parent 83aa569
commit 995381b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/packages/solidity-devops/js/forgeVerifyContract.js b/packages/solidity-devops/js/forgeVerifyContract.js
@@ -24,11 +24,12 @@ if (!deployment) {
 }
 const chainVerificationOptions = readChainVerificationOptions(chainName)
 if (!chainVerificationOptions) {
-  process.exit(0)
+  process.exit(1)
 }
 const { address, constructorArgs } = deployment
 if (!address) {
   logError(`Missing address in deployment file for ${contractAlias}`)
+  process.exit(1)
   process.exit(0)
 }
 if (!constructorArgs) {

diff --git a/packages/solidity-devops/js/utils/etherscan.js b/packages/solidity-devops/js/utils/etherscan.js
@@ -64,7 +64,7 @@ const getRequestStatus = (chainName, actionName, guid) => {
     }
     return response
   }
-  logError(`Request not completed after ${MAX_ATTEMPTS} attempts`)
+  logError(`Request with GUID ${guid} not completed after ${MAX_ATTEMPTS} attempts. Consider checking the network status or increasing the retry interval.`)
   return null
 }
 

diff --git a/packages/solidity-devops/js/verifyProxy.js b/packages/solidity-devops/js/verifyProxy.js
@@ -22,16 +22,17 @@ if (!deployment) {
 const { address } = deployment
 if (!address) {
   logError(`Missing address in deployment file for ${contractAlias}`)
-  process.exit(0)
+  process.exit(1)
 }
 
 const guid = initiateVerifyProxy(chainName, address)
 if (!guid) {
-  process.exit(0)
+  process.exit(1)
+}
 }
 const response = getRequestStatus(chainName, 'checkproxyverification', guid)
 if (!response) {
-  process.exit(0)
+  process.exit(1)
 }
 if (response.status === '0') {
   logError(`Verification failed: ${response.result}`)