Skip to content

Commit

Permalink
shadowing fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
trajan0x committed Sep 4, 2023
1 parent 9be03a5 commit 2920feb
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions packages/contracts-core/contracts/Destination.sol
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ contract Destination is ExecutionHub, DestinationEvents, InterfaceDestination {

// ═════════════════════════════════════════ CONSTRUCTOR & INITIALIZER ═════════════════════════════════════════════

constructor(uint32 synapseDomain, address agentManager_, address inbox_)
AgentSecured("0.0.3", synapseDomain, agentManager_, inbox_)
constructor(uint32 synapseDomain_, address agentManager_, address inbox_)
AgentSecured("0.0.3", synapseDomain_, agentManager_, inbox_)
{} // solhint-disable-line no-empty-blocks

/// @notice Initializes Destination contract:
Expand Down
2 changes: 1 addition & 1 deletion packages/contracts-core/contracts/GasOracle.sol
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ contract GasOracle is MessagingBase, GasOracleEvents, InterfaceGasOracle {

// ═════════════════════════════════════════ CONSTRUCTOR & INITIALIZER ═════════════════════════════════════════════

constructor(uint32 synapseDomain, address destination_) MessagingBase("0.0.3", synapseDomain) {
constructor(uint32 synapseDomain_, address destination_) MessagingBase("0.0.3", synapseDomain_) {

Check notice

Code scanning / Slither

Missing zero address validation Low

destination = destination_;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/contracts-core/contracts/Summit.sol
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ contract Summit is SnapshotHub, SummitEvents, InterfaceSummit {

// ═════════════════════════════════════════ CONSTRUCTOR & INITIALIZER ═════════════════════════════════════════════

constructor(uint32 synapseDomain, address agentManager_, address inbox_)
AgentSecured("0.0.3", synapseDomain, agentManager_, inbox_)
constructor(uint32 synapseDomain_, address agentManager_, address inbox_)
AgentSecured("0.0.3", synapseDomain_, agentManager_, inbox_)
{
if (localDomain != synapseDomain) revert MustBeSynapseDomain();
}
Expand Down
2 changes: 1 addition & 1 deletion packages/contracts-core/contracts/inbox/Inbox.sol
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ contract Inbox is StatementInbox, InboxEvents, InterfaceInbox {

// ═════════════════════════════════════════ CONSTRUCTOR & INITIALIZER ═════════════════════════════════════════════

constructor(uint32 synapseDomain) MessagingBase("0.0.3", synapseDomain) {
constructor(uint32 synapseDomain_) MessagingBase("0.0.3", synapseDomain_) {
if (localDomain != synapseDomain) revert MustBeSynapseDomain();
}

Expand Down
2 changes: 1 addition & 1 deletion packages/contracts-core/contracts/inbox/LightInbox.sol
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ contract LightInbox is StatementInbox, InterfaceLightInbox {

// ═════════════════════════════════════════ CONSTRUCTOR & INITIALIZER ═════════════════════════════════════════════

constructor(uint32 synapseDomain) MessagingBase("0.0.3", synapseDomain) {
constructor(uint32 synapseDomain_) MessagingBase("0.0.3", synapseDomain_) {
if (localDomain == synapseDomain) revert SynapseDomainForbidden();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ contract BondingManager is AgentManager, InterfaceBondingManager {

// ═════════════════════════════════════════ CONSTRUCTOR & INITIALIZER ═════════════════════════════════════════════

constructor(uint32 _synapseDomain) MessagingBase("0.0.3", _synapseDomain) {
constructor(uint32 synapseDomain_) MessagingBase("0.0.3", synapseDomain_) {
if (localDomain != synapseDomain) revert MustBeSynapseDomain();
}

Expand Down

0 comments on commit 2920feb

Please sign in to comment.