Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fortrabbit deployment guide + index listing #6291

Closed
wants to merge 8 commits into from

Conversation

ostark
Copy link
Contributor

@ostark ostark commented Feb 19, 2016

This guide helps symfony developers getting started on fortrabbit.com.

@javiereguiluz
Copy link
Member

@ostark the syntax of your article is mostly right. However, we need lines to be wrapped at around 80 characters (we don't use "soft wraps" at the Symfony docs). Thanks!

@ostark
Copy link
Contributor Author

ostark commented Feb 19, 2016

@javiereguiluz Thanks for letting me know.

Environment Variables
~~~~~~~~~~~~~~~~~~~~~

Set the `SYMFONY_ENV` environment variable to `prod` to make sure the right
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor syntax issue here. In Markdown you use 1 backtick, but in RST files you need 2 backticks:

`SYMFONY_ENV` ...  `prod`

should be:

``SYMFONY_ENV`` ...  ``prod``

@javiereguiluz
Copy link
Member

Although I don't have experience with fortrabbit, the article looked very informative and easy to follow. I've left some minor comments but overall I'm 👍 for including this article. Thanks @ostark.

@ostark
Copy link
Contributor Author

ostark commented Feb 21, 2016

Thanks for your efforts! @javiereguiluz will have a look at your suggestions tomorrow.

Setting up fortrabbit
---------------------

Before we begin, you should have done a few things on the fortrabbit side:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We avoid use "I" or "we" in the documentation.

@ostark
Copy link
Contributor Author

ostark commented Feb 23, 2016

Thank you for your help @xabbuh & @javiereguiluz!
Hopefully this time everything is correct.

official fortrabbit `Symfony install guide`_.



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use one blank line (same applies to several places below).

@xabbuh
Copy link
Member

xabbuh commented Feb 23, 2016

@ostark Sorry, I didn't have a enough time to finish my review yesterday. I did that now and left some more minor comments. Overall, the article looks very well (I cannot say anything about how that works as I didn't use fortrabbit yet though).

@ostark
Copy link
Contributor Author

ostark commented Feb 26, 2016

@xabbuh Thanks again for taking care! I hope I didn't messed up anything.

@xabbuh
Copy link
Member

xabbuh commented Feb 27, 2016

👍

wouterj added a commit that referenced this pull request Mar 5, 2016
This PR was squashed before being merged into the 2.3 branch (closes #6291).

Discussion
----------

fortrabbit deployment guide + index listing

This guide helps symfony developers getting started on fortrabbit.com.

Commits
-------

9ff4c63 fortrabbit deployment guide + index listing
@wouterj
Copy link
Member

wouterj commented Mar 5, 2016

Thank you for your amazing work on this article, @ostark! It reads really well.

I've made some minor changes in c7df320. As I don't use fortrabbit either, it would be nice if you can validate them :).

@wouterj wouterj closed this Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants