Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the invalidate_session option #6191

Closed

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets -

I found this missing doc while closing symfony/symfony#9543 and checking out the given reference to http://stackoverflow.com/questions/17129782/symfony2-logging-out-of-one-firewall

By default, the session of the user is invalidated after the log out process.
This means that the user will be logged out for all the firewalls defined in
your application. Set this option to ``false`` to only log out from the current
firewall.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe some note has to be added that this only applies to the current firewall the user logouts from. So if you always want a user not be logged out in any other firewall, you have to set this to false for every firewall defined.

@wouterj
Copy link
Member

wouterj commented Jan 27, 2016

👍 (build failure is not your fault)

@javiereguiluz
Copy link
Member Author

I've reworded the explanation to avoid adding the additional note. Please let me know what you think. Thanks!

xabbuh added a commit that referenced this pull request Jan 30, 2016
This PR was squashed before being merged into the 2.3 branch (closes #6191).

Discussion
----------

Document the invalidate_session option

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | -

I found this missing doc while closing symfony/symfony#9543 and checking out the given reference to http://stackoverflow.com/questions/17129782/symfony2-logging-out-of-one-firewall

Commits
-------

291dc5a Document the invalidate_session option
xabbuh added a commit that referenced this pull request Jan 30, 2016
@xabbuh
Copy link
Member

xabbuh commented Jan 30, 2016

Thanks Javier. I have merged your changes and fixed the build in c0d2bac.

@xabbuh xabbuh closed this Jan 30, 2016
xabbuh added a commit that referenced this pull request Jan 30, 2016
* 2.3:
  [#6191] fix build
  Document the invalidate_session option
  Docs do not match functionality
  fix MongoDB shell syntax highlighting
  Added the missing namespace in example of a subscriber class
  Typofix for "Defining and Processing Configuration Values"
xabbuh added a commit that referenced this pull request Jan 30, 2016
* 2.7:
  [#6174] tweak the event description
  [#6191] fix build
  Document the invalidate_session option
  Docs do not match functionality
  Missing reference docs for kernel.finish_request event
  fix MongoDB shell syntax highlighting
  Added the missing namespace in example of a subscriber class
  Update templating.rst
  Typofix for "Defining and Processing Configuration Values"
xabbuh added a commit that referenced this pull request Jan 30, 2016
* 2.8:
  [#6174] tweak the event description
  [#6191] fix build
  Document the invalidate_session option
  [#6204] fix CS
  Expected: semicolon
  Docs do not match functionality
  Missing reference docs for kernel.finish_request event
  fix MongoDB shell syntax highlighting
  Added the missing namespace in example of a subscriber class
  Update templating.rst
  Typofix for "Defining and Processing Configuration Values"
xabbuh added a commit that referenced this pull request Jan 30, 2016
* 3.0:
  [#6174] tweak the event description
  [#6191] fix build
  Document the invalidate_session option
  [#6204] fix CS
  Expected: semicolon
  Docs do not match functionality
  Missing reference docs for kernel.finish_request event
  fix MongoDB shell syntax highlighting
  Added the missing namespace in example of a subscriber class
  Update templating.rst
  Typofix for "Defining and Processing Configuration Values"
  Latest demo has no bin folder
@javiereguiluz javiereguiluz deleted the document_invalidate_session branch May 24, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants