Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev_environment.rst #5995

Closed
wants to merge 1 commit into from
Closed

Update dev_environment.rst #5995

wants to merge 1 commit into from

Conversation

gonzalovilaseca
Copy link
Contributor

As per the config docs:
delivery_whitelist: Used in combination with delivery_address. If set, emails matching any of these patterns will be delivered like normal, as well as being sent to delivery_address.

As per the config docs:
delivery_whitelist: Used in combination with delivery_address. If set, emails matching any of these patterns will be delivered like normal, as well as being sent to delivery_address.
@wouterj
Copy link
Member

wouterj commented Dec 17, 2015

👍 I can confirm this correct from the code. Thank you for submitting it!

except messages sent to the ``admin@mydomain.com`` address or to any email
address belonging to the domain ``specialdomain.com``, which will be delivered as normal.
and messages sent to the ``admin@mydomain.com`` address or to any email
address belonging to the domain ``specialdomain.com`` will be delivered as normal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] will also be [...]

@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2015

In the code blocks above this paragraph are comments that need to be update ("all email ddresses matching this regex will not be redirected to dev@example.com" and "all emails sent to dmin@mydomain.com won't be redirected to dev@example.com too").

@gonzalovilaseca
Copy link
Contributor Author

Ok, will update asap

wouterj added a commit that referenced this pull request Feb 7, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #5995).

Discussion
----------

Update dev_environment.rst

As per the config docs:
delivery_whitelist: Used in combination with delivery_address. If set, emails matching any of these patterns will be delivered like normal, as well as being sent to delivery_address.

Commits
-------

fc6b0a6 Update dev_environment.rst
wouterj added a commit that referenced this pull request Feb 7, 2016
@wouterj
Copy link
Member

wouterj commented Feb 7, 2016

Thank you for discovering this misdocumented feature and submitting a nice fix! I've merged your changes into the 2.3 docs (that's why the status is closed instead of merged) and updated the code comments in 20ad31d.

@wouterj wouterj closed this Feb 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants