Do not use dynamic REQUEST_URI from $_SERVER as base url #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senkal
changed the title
|
@weaverryan It seems like you did that initial change. Do you know why |
|
:thumbs: I agree - I think I just made a quick mistake - I can't remember anything specific related to this |
|
👍 |
|
Thank you @senkal. |
xabbuh
added a commit
that referenced
this pull request
Sep 8, 2015
…(senkal) This PR was merged into the 2.3 branch. Discussion ---------- Do not use dynamic REQUEST_URI from $_SERVER as base url | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | I am not sure why we use `$_SERVER['REQUEST_URI']` as a first parameter for `Symfony\Component\Routing\RequestContext` where it expects to get baseUrl. `$_SERVER['REQUEST_URI'] ` is dynamic and shouldn't be used as a static value for baseUrl. Probably better not to pass this parameter at all(default) or use `/`, what I propose. I know that many people won't look that deeply into those examples but, in my opinion, `$_SERVER['REQUEST_URI'] ` is not base url. Not sure what to do with the note about the request uri(the one with http foundation link/info). Maybe the idea was to use `$_SERVER['REQUEST_URI']` in `->match()` examples ? Commits ------- dadefb6 Od not use dynamic REQUEST_URI from $_SERVER as base url
xabbuh
added a commit
that referenced
this pull request
Oct 4, 2015
…g component (senkal) This PR was squashed before being merged into the 2.3 branch (closes #5678). Discussion ---------- Update HttpFoundation note after recent changes in routing component | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Update HttpFoundation note to reflect changes in #5652. We do not longer use `$_SERVER['REQUEST_URI']` in examples so keeping the reference in note doesn't have much value. I updated it to make it more generic and reflect current examples. Commits ------- 36234f2 Update HttpFoundation note after recent changes in routing component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why we use
$_SERVER['REQUEST_URI']as a first parameter forSymfony\Component\Routing\RequestContextwhere it expects to get baseUrl.$_SERVER['REQUEST_URI']is dynamic and shouldn't be used as a static value for baseUrl.Probably better not to pass this parameter at all(default) or use
/, what I propose.I know that many people won't look that deeply into those examples but, in my opinion,
$_SERVER['REQUEST_URI']is not base url.Not sure what to do with the note about the request uri(the one with http foundation link/info).
Maybe the idea was to use
$_SERVER['REQUEST_URI']in->match()examples ?