Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Add $groups and $payload to Compound constructor #20152

Open
fabpot opened this issue Aug 22, 2024 · 2 comments
Open

[Validator] Add $groups and $payload to Compound constructor #20152

fabpot opened this issue Aug 22, 2024 · 2 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Milestone

Comments

@fabpot
Copy link
Member

fabpot commented Aug 22, 2024

Q A
Feature PR symfony/symfony#58062
PR author(s) @derrabus
Merged in 7.2

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.

Thank you! 😃

@fabpot fabpot added this to the 7.2 milestone Aug 22, 2024
@thibaut22200
Copy link
Contributor

thibaut22200 commented Aug 27, 2024

Can be closed:

Already in reference/constraints/Compound.rst

l.105 to l.110
Options
-------

.. include:: /reference/constraints/_groups-option.rst.inc

.. include:: /reference/constraints/_payload-option.rst.inc

@derrabus
Copy link
Member

Those are the options, not the constructor arguments. What's new is that those options can be set through names arguments. Maybe we should show on https://symfony.com/doc/current/reference/constraints/Compound.html a custom compound constraint used as an attribute with a validation group.

@OskarStark OskarStark changed the title [Validator] Add $groups and $payload to Compound constructor [Validator] Add $groups and $payload to Compound constructor Aug 27, 2024
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Development

No branches or pull requests

5 participants