[Serializer] Add SnakeCaseToCamelCaseNameConverter
#20160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Aug 24, 2024
components/serializer.rst
Outdated
| $normalizer->normalize($kevin); | ||
| // ['first_name' => 'Kévin']; | ||
|
|
||
| $anne = $normalizer->denormalize(['first_name' => 'Anne'], 'Person'); |
There was a problem hiding this comment.
The example here seems to be the same as the one for the CamelCaseToSnakeCaseNameConverter. That doesn't look right to me.
There was a problem hiding this comment.
@xabbuh Fixed the example, thanks you.
OskarStark
changed the title
SnakeCaseToCamelCaseNameConverter
thibaut22200
force-pushed
the
20151-add-doc
branch
from
89c84d5
to
4303a89
Compare
thibaut22200
force-pushed
the
20151-add-doc
branch
from
4303a89
to
1a9afff
Compare
|
I think there is still some misunderstanding. When the name converter is being used the name of the property is converted but not the value. So I would expect a class with a property like |
OskarStark
reviewed
Sep 3, 2024
Comment on lines
+645
to
+663
| class Person | ||
| { | ||
| public function __construct( | ||
| private string $fullName, | ||
| ) { | ||
| } | ||
|
|
||
| public function getFullName(): string | ||
| { | ||
| return $this->fullName; | ||
| } | ||
| } | ||
|
|
||
| $john = new Person('john_doe'); | ||
| $normalizer->normalize($john); | ||
| // ['full_name' => 'johnDoe']; | ||
|
|
||
| $john = $normalizer->denormalize(['full_name' => 'johnDoe'], 'Person'); | ||
| // Person object with fullName: 'jonh_doe' |
There was a problem hiding this comment.
Suggested change
| class Person | |
| { | |
| public function __construct( | |
| private string $fullName, | |
| ) { | |
| } | |
| public function getFullName(): string | |
| { | |
| return $this->fullName; | |
| } | |
| } | |
| $john = new Person('john_doe'); | |
| $normalizer->normalize($john); | |
| // ['full_name' => 'johnDoe']; | |
| $john = $normalizer->denormalize(['full_name' => 'johnDoe'], 'Person'); | |
| // Person object with fullName: 'jonh_doe' | |
| class Person | |
| { | |
| public function __construct( | |
| private string $full_name, | |
| ) { | |
| } | |
| public function getFullName(): string | |
| { | |
| return $this->full_name; | |
| } | |
| } | |
| $john = new Person('john'); | |
| $normalizer->normalize($john); | |
| // ['fullName' => 'john']; | |
| $john = $normalizer->denormalize(['fullName' => 'john'], 'Person'); | |
| // $john->getFullName() -> 'john' |
cc @xabbuh
There was a problem hiding this comment.
I am not sure if it works this way when the property is not public and the getter has a camel case name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document symfony/symfony#58060
and closes #20151