Unpaired surrogates in strings are not handled correctly

[chris-morgan]

This can lead to astral plane characters like emoji and characters in some other languages getting turned into ��. Details at Pauan/rust-dominator#10 and the related issues that got created at around that time.

A simple way of synthesising this on the hello example without needing specific Windows software:

const input = document.querySelector('input');
input.value = 'hello\ud83d';
input.dispatchEvent(new CustomEvent('input'));

The input’s value should be hello\ud83d, but instead ends up hello\ufffd, which is wrong.

[lukechu10]

rustwasm/wasm-bindgen#1348 has been closed so I think this should now be closed as well.

[chris-morgan]

It was closed because it had gone as far as it could, adding new methods to check whether conversion would be lossless, and documenting things; but the conclusion there is pretty much “it’s up to users to use it correctly”. And that’s what Sycamore is not doing. Run the sample code against the TodoMVC example (since the hello example is gone) and you’ll see it’s still broken. This should be reopened.

[lukechu10]

Ah OK. I only took a quick look at the closed issues. I will reopen this now.