Check mode Field #100
Merged
Check mode Field #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laelliott
approved these changes
May 9, 2024
|
May I ask why you changed this in process_data_gps() but not process_data_navsat()? I just stumbled over this since status field on the /fix topic is now -1 on my system, while on /extended_fix it seems correctly reported. The navsat_transform_node of robot_localization will not publish any transform if status is -1. #50 might be related. |
|
That is an error on my part. I will make them work the same way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for valid fix based on the mode field instead of the status. This simplifies the logic and makes it easier to accept new fix types in the GPSD API.