You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small PR attached for this one file issue. I lost a couple of hours to this (path with dash instead of underscore, arg!).
There are many other occurrences of except: pass or except: return None throughout the project. Almost all of those could/should be improved. I don't have the context for the original author's decision so difficult to say what they were expecting might fail. Example from technique.py:
Small PR attached for this one file issue. I lost a couple of hours to this (path with dash instead of underscore, arg!).
There are many other occurrences of
except: pass
orexcept: return None
throughout the project. Almost all of those could/should be improved. I don't have the context for the original author's decision so difficult to say what they were expecting might fail. Example fromtechnique.py
:Where did the author think this might fail? Is that okay? What error is actually raised? Should it really be ignored?
I will not be working through these other items but they should probably be on somebody's TODO list.
Originally posted by @mcarpenter in #93 (comment)
The text was updated successfully, but these errors were encountered: