-
-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove color.ui settings #43
Conversation
As explained in the [git documentation](http://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#Colors-in-Git) the configuration variable `color.ui` is set to `auto` by default. There's no need to tell students to set this variable themselves.
On Thu, Feb 12, 2015 at 02:42:32PM -0800, Andrea Bedini wrote:
That's just the Pro Git book (which is pretty good, but versioned $ git config --help I'm not sure how far back we want to support Git clients. 1.8.4 was |
OSX now ships with git version 1.9.3, I guess Windows users can install the latest version of git (since they have to install git anyway). Anyway, I reckon missing on ui colors is acceptable compromise for who is stuck with an old version of git. In the end, the less things we configure the better. |
On Thu, Feb 12, 2015 at 03:21:18PM -0800, Andrea Bedini wrote:
For folks who are running the current OS X ;). Just because new
I agree with the idea here, I'm just not sure how long our support |
I'd vote for leaving this as is for now. I can tell you from the trenches that we get plenty of people with ancient operating systems in our workshops. Random thought: It could be an interesting extra challenge in |
@jiffyclub there's little to none content about using the git configuration system in the lesson, I don't think we need to include practice on that. I'd like to reiterate the main point: the additional obscure configuration option is not worth the gain (the colour ui). People using old system can live without. |
I disagree with your premise, it is absolutely worth turning on the color UI. |
I'd also vote for leaving it for now. I think it's not that much intrusive, allows us to support outdated OSes, and gives the instructor the chance to introduce, even briefly, the git config system. I'm closing it without merging for now. Thanks in any case, @andreabedini. |
As explained in the git documentation the configuration variable
color.ui
is set toauto
by default. There's no need to tell students to set this variable themselves.