Skip to content
This repository has been archived by the owner on Jan 3, 2018. It is now read-only.

Do we have a minimum / maximum IPython version? #724

Closed
wking opened this issue Sep 18, 2014 · 15 comments
Closed

Do we have a minimum / maximum IPython version? #724

wking opened this issue Sep 18, 2014 · 15 comments

Comments

@wking
Copy link
Contributor

wking commented Sep 18, 2014

I see the README recommends IPython >= 1.0, but the check-script is still only looking for >= 0.13. I just noticed that the busy bees at IPython have recently cut 2.2.0. IPython 2.x has a bunch of changes including deprecating the file/ prefix for local files and adding a modal interface. Are we just trying to keep up with the most recent version? Are we even supporting the most recent versions? If we're supporting a range of versions, what's the range? I don't know if we have a policy for this yet, but I think we should have one soon.

@jiffyclub
Copy link
Contributor

People installing Anaconda are going to get IPython 2. For most practical purposes it works the same as IPython 1, but there is the difference of the modal interface and the file system browser. I expect a student running IPython 1 in a workshop would be fine, so we could stick with that as a minimum version maybe until IPython 3 comes out.

@wking
Copy link
Contributor Author

wking commented Sep 18, 2014

On Thu, Sep 18, 2014 at 11:29:40AM -0700, Matt Davis wrote:

People installing Anaconda are going to get IPython 2. For most
practical purposes it works the same as IPython 1, but there is the
difference of the modal interface and the file system browser. I
expect a student running IPython 1 in a workshop would be fine, so
we could stick with that as a minimum version maybe until IPython 3
comes out.

Are our filled-in notebooks compatible with both the 1.x and 2.x
series? Major version bumps usually signify that there has been some
backwards-incompatible change, but I'm not current enough on IPython
to know if that was the case here (or if it was, but we're not
affected by that change).

@jiffyclub
Copy link
Contributor

I just did a quick check of opening a 2.2 made notebook with IPython 1.1 and it worked fine. There were some new features in IPython 2 like notebook signing and the idea of "trusted" notebooks, but the format seems to be compatible with IPython 1.

@ethanwhite
Copy link
Contributor

On Thu, Sep 18, 2014 at 12:40 PM, Matt Davis notifications@github.com wrote:

I just did a quick check of opening a 2.2 made notebook with IPython 1.1 and
it worked fine. There were some new features in IPython 2 like notebook
signing and the idea of "trusted" notebooks, but the format seems to be
compatible with IPython 1.

That is correct.

@wking
Copy link
Contributor Author

wking commented Sep 18, 2014

On Thu, Sep 18, 2014 at 11:40:04AM -0700, Matt Davis wrote:

I just did a quick check of opening a 2.2 made notebook with IPython
1.1 and it worked fine. There were some new features in IPython 2
like notebook signing and the idea of "trusted" notebooks, but the
format seems to be compatible with IPython 1.

So maybe I should bump the minimum version in
swc-installation-test-2.py to 1.0, and just leave it at that until
they release IPython 3.0?

@ethanwhite
Copy link
Contributor

On Thu, Sep 18, 2014 at 1:09 PM, W. Trevor King
notifications@github.com wrote:

So maybe I should bump the minimum version in
swc-installation-test-2.py to 1.0, and just leave it at that until
they release IPython 3.0?

+1

@jiffyclub
Copy link
Contributor

Sounds reasonable.

@wking
Copy link
Contributor Author

wking commented Sep 18, 2014

On Thu, Sep 18, 2014 at 12:08:36PM -0700, W. Trevor King wrote:

So maybe I should bump the minimum version in
swc-installation-test-2.py to 1.0, and just leave it at that until
they release IPython 3.0?

Do we want to mention this range of versions in the install
instructions? Or are we just suggesting everyone installs Anaconda,
and not providing alternative package lists for folks who want to use
their OS's native packages?

@jiffyclub
Copy link
Contributor

I wouldn't want it in the main installation instructions since we tell everyone to install Anaconda. Separate version notes for every package we use would get unwieldy. Maybe just a pointer to the checking script for people who want to verify existing installations?

@wking
Copy link
Contributor Author

wking commented Sep 18, 2014

On Thu, Sep 18, 2014 at 01:17:47PM -0700, Matt Davis wrote:

I wouldn't want it in the main installation instructions since we
tell everyone to install Anaconda. Separate version notes for every
package we use would get unwieldy. Maybe just a pointer to the
checking script for people who want to verify existing
installations?

Yeah, sounds good.

@gvwilson
Copy link
Contributor

@jiffyclub, can you comment on this? Your IPython-fu is much greater
than mine.

@jiffyclub
Copy link
Contributor

I did, think we're good. 😸

@gvwilson
Copy link
Contributor

Can this one be closed?

@wking
Copy link
Contributor Author

wking commented Sep 30, 2014

On Tue, Sep 30, 2014 at 11:15:04AM -0700, Greg Wilson wrote:

Can this one be closed?

I haven't bumped the test script yet 1.

@wking
Copy link
Contributor Author

wking commented Oct 18, 2014

On Tue, Sep 30, 2014 at 11:19:43AM -0700, W. Trevor King wrote:

I haven't bumped the test script yet 1.

Ok, I've bumped the test script [1](and updated the namespaced [2]
and bc-namespaced [3] branches too). In the light of #759, I'm not
going to bother making a pull-request against bc. Let me know if you
want one, although I think you should just run:

$ git pull --log git://tremily.us/swc-setup-installation-test.git bc-namespaced

if you do.

@wking wking closed this as completed Oct 18, 2014
wking added a commit to carpentries/workshop-template that referenced this issue Dec 17, 2014
I see the README recommends IPython >= 1.0 [1], but this script was
only looking for >= 0.13.  The busy bees at IPython have recently cut
2.3.0 (2014-10-01 [2]).  IPython 2.x has a bunch of changes including
deprecating the file/ prefix for local files [3] and adding a modal
interface [4].  I asked for feedback on what versions we were
supporting, and got this from Matt [5]:

On Thu, Sep 18, 2014 at 11:40:04AM -0700, Matt Davis wrote:
> I just did a quick check of opening a 2.2 made notebook with IPython
> 1.1 and it worked fine. There were some new features in IPython 2
> like notebook signing and the idea of "trusted" notebooks, but the
> format seems to be compatible with IPython 1.

So this commit bumps the minimum version to 1.0.  We'll revisit this
compatibility after the IPython folks cut 3.0.

[1]: https://github.com/swcarpentry/bc/blob/v2014.06/README.md#faq
[2]: https://pypi.python.org/pypi/ipython/2.3.0
[3]: http://ipython.org/ipython-doc/dev/whatsnew/version2.0.html#directory-navigation
[4]: http://ipython.org/ipython-doc/dev/whatsnew/version2.0.html#modal-user-interface
[5]: swcarpentry/DEPRECATED-bc#724 (comment)
wking added a commit to wking/swc-setup-installation-test that referenced this issue Mar 5, 2015
…ions

With [1], we can mostly point folks to the right place if we can't
find a particular package.

There's some funkiness around editors, since most of our editor
instructions are just links to the upstream projects, and we have
different suggestions for each operating system.

We're also pointing most users at Anaconda, instead of listing the
packages we need explicitly [2,3,4], it's hard to know which specific
PythonPackageDependencies should also link to #python-{system}.  I've
left them off entirely for now, but instructors who want to link to
their setup instructions when we can get a Python version but not, for
example, a NumPy version should add a ('numpy', 'python') entry to the
check/check_id loop.

[1]: carpentries/workshop-template#171
[2]: swcarpentry/DEPRECATED-bc#724 (comment)
[3]: swcarpentry/DEPRECATED-bc#724 (comment)
[4]: swcarpentry/DEPRECATED-bc#724 (comment)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants