Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/typescript): Fix ASI in expression for fast strip #9358

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari requested a review from a team as a code owner July 31, 2024 12:47
Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 95c804f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Jul 31, 2024
@kdy1 kdy1 self-assigned this Jul 31, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 31, 2024 13:03
@kdy1 kdy1 changed the title fix(es/typescript): Fix ASI in expression for TypeScript strip fix(es/typescript): Fix ASI in expression for fast strip Jul 31, 2024
@kdy1 kdy1 merged commit 3ee82e2 into swc-project:main Jul 31, 2024
154 checks passed
Copy link

codspeed-hq bot commented Jul 31, 2024

CodSpeed Performance Report

Merging #9358 will improve performances by 4.89%

Comparing magic-akari:fix/fast-ts-strip/asi (95c804f) with magic-akari:fix/fast-ts-strip/asi (4567f4f)

Summary

⚡ 1 improvements
✅ 177 untouched benchmarks

Benchmarks breakdown

Benchmark magic-akari:fix/fast-ts-strip/asi magic-akari:fix/fast-ts-strip/asi Change
es/full/bugs-1 571.2 µs 544.6 µs +4.89%

@kdy1 kdy1 modified the milestones: Planned, v1.7.4 Jul 31, 2024
@magic-akari magic-akari deleted the fix/fast-ts-strip/asi branch August 7, 2024 06:13
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fast TS has a bug related to ASI
2 participants