Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build swc, due using #![deny(unused)] lint #9182

Closed
qarmin opened this issue Jul 9, 2024 · 2 comments · Fixed by #9206
Closed

Cannot build swc, due using #![deny(unused)] lint #9182

qarmin opened this issue Jul 9, 2024 · 2 comments · Fixed by #9206
Assignees
Milestone

Comments

@qarmin
Copy link

qarmin commented Jul 9, 2024

Describe the bug

When compiling swc in github CI, I cannot compile it with commands

cargo default nightly
wget -q https://github.com/swc-project/swc/archive/refs/heads/main.zip
unzip -q main.zip
cargo install --path swc-main/crates/swc_cli_impl/ --locked
rm -rf main.zip swc-main

due error

 warning: `swc_ecma_usage_analyzer` (lib) generated 51 warnings
   Compiling swc_ecma_transforms_module v0.183.1 (/home/runner/work/Automated-Fuzzer/Automated-Fuzzer/swc-main/crates/swc_ecma_transforms_module)
error: struct `Exports` is never constructed
   --> crates/swc_ecma_transforms_module/src/util.rs:233:19
    |
233 | pub(super) struct Exports(#[allow(dead_code)] pub Ident);
    |                   ^^^^^^^
    |
note: the lint level is defined here
   --> crates/swc_ecma_transforms_module/src/lib.rs:2:9
    |
2   | #![deny(unused)]
    |         ^^^^^^
    = note: `#[deny(dead_code)]` implied by `#[deny(unused)]`

error: could not compile `swc_ecma_transforms_module` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
warning: `swc_ecma_compat_es2015` (lib) generated 2 warnings

CI job - https://github.com/qarmin/Automated-Fuzzer/actions/runs/9852646353/job/27201572098

Input code

No response

Config

No response

Playground link (or link to the minimal reproduction)

not needed

SWC Info output

No response

Expected behavior

Proper compilation

Actual behavior

No response

Version

Git 3ddf63c

Additional context

No response

@qarmin qarmin added the C-bug label Jul 9, 2024
@github-actions github-actions bot closed this as completed Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository or a link to the SWC playground.

The bug template that you filled out has a section called "Link to the code that reproduces this issue", which is where you should provide the link to the reproduction.

  • If you did not provide a link or the link you provided is not valid, we will close the issue.
  • If you provide a link to a private repository, we will close the issue.
  • If you provide a link to a repository but not in the correct section, we will close the issue.

What should I do?

Depending on the reason the issue was closed, you can do the following:

  • If you did not provide a link, please open a new issue with a link to a reproduction.
  • If you provided a link to a private repository, please open a new issue with a link to a public repository.
  • If you provided a link to a repository but not in the correct section, please open a new issue with a link to a reproduction in the correct section.

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

  • Remove any code that is not related to the issue. (pages, API routes, components, etc.)
  • Remove any dependencies that are not related to the issue.
  • Remove any third-party service that would require us to sign up for an account to reproduce the issue.
  • Remove any environment variables that are not related to the issue.
  • Remove private packages that we do not have access to.
  • If the issue is not related to a monorepo specifically, try to reproduce the issue without a complex monorepo setup

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every SWC issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
@swc-project swc-project unlocked this conversation Jul 9, 2024
@kdy1 kdy1 added this to the Planned milestone Jul 9, 2024
@kdy1 kdy1 reopened this Jul 9, 2024
@kdy1 kdy1 self-assigned this Jul 11, 2024
@kdy1 kdy1 closed this as completed in efb8636 Jul 11, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@swc-bot
Copy link
Collaborator

swc-bot commented Aug 17, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

3 participants