Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/parser): Reduce allocations for raw while lexing numbers #9056

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 15, 2024

Description:

We don't need to allocate one byte at a time while lexing numbers.

@kdy1 kdy1 added this to the Planned milestone Jun 15, 2024
@kdy1 kdy1 self-assigned this Jun 15, 2024
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common --breaking

Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser --breaking

@kdy1 kdy1 marked this pull request as ready for review June 15, 2024 08:46
@kdy1 kdy1 requested a review from a team as a code owner June 15, 2024 08:46
@kdy1 kdy1 enabled auto-merge (squash) June 15, 2024 08:46
@kdy1 kdy1 disabled auto-merge June 15, 2024 08:46
@kdy1 kdy1 changed the title perf(es/parser): Do not track raw while lexing numbers perf(es/parser): Reduce allocations for raw while lexing numbers Jun 15, 2024
@kdy1 kdy1 enabled auto-merge (squash) June 15, 2024 08:47
@kdy1 kdy1 disabled auto-merge June 15, 2024 09:01
@kdy1 kdy1 merged commit bc8ec62 into swc-project:main Jun 15, 2024
148 checks passed
@kdy1 kdy1 deleted the raw-parser branch June 15, 2024 09:01
@kdy1 kdy1 modified the milestones: Planned, v1.6.0 Jun 16, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant