-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring effort #1
Comments
2023.10.11::00:16: refactored and tested verb_utils.py. added comments to suggest having it as a singular class instead of many functions. |
2023.10.29::14:00: refactored and tested |
2023.11.02::23:29: added type hints and better documentation style strings for the modules: providing module, class, and function descriptions. |
2023.11.04::22:23: completed refactoring of verb classification, leaving only disambiguation to be refactored and tested. There are still a few minor issues one such being that a certain verb class is classified based only on ending but should also be classified on its syllabilacity. Another issue is that some 'special cases' (not irregular, just a change in a letter or 2) require the unprefixed verb. |
2024.04.17::02:20: completed refactoring of conjugation utilities with completion of verb disambiguation and concrete verb determination. There is still work to be done in determining a verb's aspect (heuristically?), but where it stands now it surpasses the prior implementation.
|
2024.04.21::15:06: conjugator testing for the most part done. There is still a single BUG comment and a few TODOs (all for aspect). FIXMEs were resolved. Branch |
2024.04.22::19:02: Fixed |
Currrent code can be done better, you've gotten better at Python since you originally wrote it (more than a year ago). Can be done by doing the following:
# TODO
,# FIXME
, and# BUG
comments and resolve themverb_utils.py
conjugator_utils.py
verbs.py
conjugator.py
verb_utils.py
conjugator_utils.py
verbs.py
conjugator.py
The text was updated successfully, but these errors were encountered: