Add option for printing single quotes in markup attributes #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenjacobs
commented
Jan 7, 2022
Comment on lines
+393
to
394
| // TODO: Replace quoteCharacter with quoteReplacementCharacter in attrNodeValue | ||
| const attrNodeValue = printAttributeNodeValue(path, print, quotes, node); |
There was a problem hiding this comment.
I need some help here as I don't know how to replace characters in attrNodeValue. I'm not yet familiar with the Prettier API.
There was a problem hiding this comment.
Kindly asking for feedback / help here @Conduitry @dummdidumm @jamesbirtles
|
Still need some help here, please. |
|
Last call before I'm going to close this PR. I'm currently not using Svelte in any project (anymore) so there's not much motivation and time from my side going forward with this. @micheal-parks since you referenced this issue, do you maybe want to continue working on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #253, here's my work in progress of a new
svelteMarkupSingleQuoteoption.