Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup #10979 #11641

Closed
wants to merge 6 commits into from
Closed

chore: cleanup #10979 #11641

wants to merge 6 commits into from

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jan 15, 2024

cleans up #10979 by implementing the feedback from after the PR was merged for the issue #10594


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 15, 2024

⚠️ No Changeset found

Latest commit: 95ec444

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - @Rich-Harris maybe you want to give this another look since it's about enhancing the adapter API.

@dummdidumm dummdidumm mentioned this pull request Jan 15, 2024
@Rich-Harris
Copy link
Member

I left some comments on the other PR. I don't think we've got the right API yet. Unfortunately I'm off today so can't weigh in much more than that, so if we want to merge the release PR we should probably revert #10979 for now

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a 'request changes' making sure we don't merge this in the meantime

@eltigerchino
Copy link
Member Author

eltigerchino commented Jan 16, 2024

I’ve created a PR to revert the changes here #11644 in case we can't clean it up in time for a next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants