Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate __data.json when prerendering but SSR is turned off #10988

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

eltigerchino
Copy link
Member

fixes #10983

This PR adds a check to see if we're prerendering and SSR is turned off to avoid responding with CSR only too early. With this check in place, the should_prerender check can now be reached and generate the __data.json file.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 6, 2023

🦋 Changeset detected

Latest commit: 2364bf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit b3504eb into master Nov 9, 2023
14 checks passed
@dummdidumm dummdidumm deleted the fix-prerender-with-ssr-off-missing-dependencies branch November 9, 2023 12:10
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
dummdidumm pushed a commit that referenced this pull request Nov 14, 2023
fixes #11031

#10988 introduced a regression where the response during prerendering would always have SSR enabled. This PR fixes this by setting it according to the SSR page option.
@eltigerchino eltigerchino changed the title fix: generate __data.json when prerendering and SSR is turned off fix: generate __data.json when prerendering but SSR is turned off Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prerender=true and ssr=false mix build wrong
2 participants