fix: Fix rule merging without a match (#168)

Closes #167.
survivejs · Dec 16, 2020 · 7e8bd56 · 7e8bd56
1 parent e71aef3
commit 7e8bd56
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 0 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -192,6 +192,12 @@ function mergeWithRule({
           ret[k] = v.concat(appendValue);
           break;
         case CustomizeRule.Merge:
+          if (!bMatches.length) {
+            ret[k] = v;
+
+            break;
+          }
+
           const lastValue = last(bMatches)[k];
 
           if (!isPlainObject(v) || !isPlainObject(lastValue)) {

diff --git a/test/merge-with-rules.test.ts b/test/merge-with-rules.test.ts
@@ -1043,4 +1043,78 @@ describe("Merge with rules", function () {
       })(base, development)
     ).toEqual(result);
   });
+
+  it("should fall back to default behavior without a match when merging (#167)", function () {
+    const conf1 = {
+      module: {
+        rules: [
+          {
+            test: "/\\.scss$|\\.sass$/",
+            use: [
+              {
+                loader: "sass-loader",
+                options: {
+                  sourceMap: true,
+                },
+              },
+            ],
+          },
+        ],
+      },
+    };
+    const conf2 = {
+      module: {
+        rules: [
+          {
+            test: "/\\.scss$|\\.sass$/",
+            use: [
+              {
+                loader: "sass-resources-loader",
+                options: {
+                  resources: ["src/styles/includes.scss"],
+                },
+              },
+            ],
+          },
+        ],
+      },
+    };
+    const result = {
+      module: {
+        rules: [
+          {
+            test: "/\\.scss$|\\.sass$/",
+            use: [
+              {
+                loader: "sass-loader",
+                options: {
+                  sourceMap: true,
+                },
+              },
+              {
+                loader: "sass-resources-loader",
+                options: {
+                  resources: ["src/styles/includes.scss"],
+                },
+              },
+            ],
+          },
+        ],
+      },
+    };
+
+    expect(
+      mergeWithRules({
+        module: {
+          rules: {
+            test: CustomizeRule.Match,
+            use: {
+              loader: CustomizeRule.Match,
+              options: CustomizeRule.Merge,
+            },
+          },
+        },
+      })(conf1, conf2)
+    ).toEqual(result);
+  });
 });