Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aframe 1.5.0 THREE.Material: parameter 'glslVersion' has value of undefined. #96

Closed
vincentfretin opened this issue Nov 17, 2023 · 2 comments

Comments

@vincentfretin
Copy link
Contributor

With aframe 1.5.0, we have a warning "THREE.Material: parameter 'glslVersion' has value of undefined."
I didn't quite follow the threejs changes wth glslVersion. I know @mrxz you participated in the discussion around this in aframe repo, you may now how to remove the warning and keep it compatible with both 1.4.2 and 1.5.0.

@mrxz
Copy link
Contributor

mrxz commented Nov 17, 2023

This seems to be an oversight in the changes from aframevr/aframe#5328. Quite surprising given the many iterations, discussion and testing that took place on it. I'd assume this warning would've caught the attention at some point, but alas.

Basically A-Frame now falls back to undefined for glslVersion in case of non-raw shaders (shader.js#L58). However the default value in Three.js is null (ShaderMaterial.js#L53). Fix is straightforward, but needs to happen in A-Frame, will create a PR for it shortly

@vincentfretin
Copy link
Contributor Author

Thanks you! The warning will be fixed in aframe 1.5.1 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants