Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phx: less brittle node naming for dns_cluster #3993

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

phx: less brittle node naming for dns_cluster #3993

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
903f7f4
phx: less brittle node naming for dns_cluster
clutterstack Oct 10, 2024
5ac24b6
should really be tag, not label
clutterstack Oct 10, 2024
8713bc3
Merge branch 'master' into phx-erlang-node
clutterstack Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scanner/phoenix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ export ERL_AFLAGS="-proto_dist inet6_tcp"
export ECTO_IPV6="true"
export DNS_CLUSTER_QUERY="${FLY_APP_NAME}.internal"
export RELEASE_DISTRIBUTION="name"
export RELEASE_NODE="${FLY_APP_NAME}-${FLY_IMAGE_REF##*-}@${FLY_PRIVATE_IP}"
image_tag="${FLY_IMAGE_REF##*:}"
# trim the non-unique part of the default Fly.io label for the node name
export RELEASE_NODE="${FLY_APP_NAME}-${image_tag#deployment-}@${FLY_PRIVATE_IP}"

# Uncomment to send crash dumps to stderr
# This can be useful for debugging, but may log sensitive information
Expand Down
Loading