Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make Postgres tests more stable #3857

Merged
merged 3 commits into from
Aug 19, 2024
Merged

test: make Postgres tests more stable #3857

merged 3 commits into from
Aug 19, 2024

Conversation

kzys
Copy link
Member

@kzys kzys commented Aug 15, 2024

Change Summary

What and Why:

How:

Related to:

Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

@ndarilek
Copy link
Contributor

It's hard for me to scrape through all these failures, but I see there are still 11. Has the size bump reduced the number of Postgres-related failures any?

@kzys kzys force-pushed the large-postgres-vm branch 3 times, most recently from bc5b184 to d702ea4 Compare August 17, 2024 00:54
@kzys
test: make Postgres machines bigger
674e9aa 
shared-cpu-1x might be too small.
@kzys
test: wait machines longer
277cd23 
`fly pg import` starts a disposable machine. Sometimes that lingers
longer than we expected.
@kzys kzys changed the title fix: make postgres machines bigger test: make Postgres tests more stable Aug 17, 2024
@kzys kzys marked this pull request as ready for review August 17, 2024 03:10
matttpt
matttpt approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@matttpt matttpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, any reason for switching some of these from require to assert? Otherwise, LGTM!

@kzys
Copy link
Member Author

kzys commented Aug 19, 2024

require.* assertions kills the test right away. For cases where you could continue the execution of a test, it would be better to use assert.* functions. You can get more information from one test failure.

@kzys kzys merged commit 885dd16 into master Aug 19, 2024
35 checks passed
@kzys kzys deleted the large-postgres-vm branch August 19, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matttpt matttpt matttpt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kzys @ndarilek @matttpt