Adding the user who created a token to the flyctl token list command #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btoews
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Added a
created bycolumn to thefly tokens listapp and org scope so someone can figure out who created the tokens in an org if they ever need to revoke them. This info is currently exposed inui-exbut the UX of going through all org/app tokens in an org an revoking them is pretty painful.How:
Changed the user field in
LimitedAccessTokensto publicRelated to:
superfly/fly-go#25
https://github.com/superfly/web/pull/2909
https://flyio.slack.com/archives/C035ZMAM206/p1710767524505839?thread_ts=1710737001.723769&cid=C035ZMAM206