Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve API for ExtensionContext and export marker.dart #1273

Merged
merged 1 commit into from
May 18, 2023

Conversation

Sub6Resources
Copy link
Owner

@Sub6Resources Sub6Resources commented May 18, 2023

Fixes #1272
Fixes #1252

This simplifies the API for classes extending HtmlExtension by moving information about children to the ExtensionContext.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 72.41% and project coverage change: +0.18 🎉

Comparison is base (15cb05e) 59.85% compared to head (9fde184) 60.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
+ Coverage   59.85%   60.04%   +0.18%     
==========================================
  Files          37       37              
  Lines        2698     2698              
==========================================
+ Hits         1615     1620       +5     
+ Misses       1083     1078       -5     
Impacted Files Coverage Δ
lib/src/builtins/details_element_builtin.dart 11.11% <0.00%> (ø)
lib/src/builtins/image_builtin.dart 60.39% <ø> (ø)
lib/src/builtins/ruby_builtin.dart 92.06% <ø> (ø)
lib/src/builtins/text_builtin.dart 96.15% <ø> (ø)
lib/src/extension/helpers/image_extension.dart 0.00% <0.00%> (ø)
lib/src/extension/helpers/image_tap_extension.dart 0.00% <0.00%> (ø)
lib/src/extension/helpers/matcher_extension.dart 53.84% <ø> (ø)
lib/src/extension/helpers/tag_extension.dart 66.66% <ø> (ø)
lib/src/extension/html_extension.dart 81.25% <0.00%> (ø)
lib/src/processing/lists.dart 90.90% <ø> (ø)
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sub6Resources Sub6Resources merged commit 27e33a9 into master May 18, 2023
@Sub6Resources Sub6Resources deleted the fix/api-improvements branch May 18, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widget should export src/style/marker.dart [BUG] Simple non-wrapped children are not rendered
1 participant