Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a tag should not style as link if href is not provided #1265

Merged
merged 1 commit into from
May 15, 2023

Conversation

Sub6Resources
Copy link
Owner

Fixes #1092

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@2ffa1dd). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4cf38e6 differs from pull request most recent head b7facb5. Consider uploading reports for the commit b7facb5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1265   +/-   ##
=========================================
  Coverage          ?   58.07%           
=========================================
  Files             ?       36           
  Lines             ?     2607           
  Branches          ?        0           
=========================================
  Hits              ?     1514           
  Misses            ?     1093           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/src/builtins/interactive_element_builtin.dart 94.59% <100.00%> (ø)
lib/src/builtins/styled_element_builtin.dart 96.81% <100.00%> (ø)
lib/src/processing/relative_sizes.dart 70.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sub6Resources Sub6Resources merged commit d7247cb into master May 15, 2023
@Sub6Resources Sub6Resources deleted the fix/a-issues branch May 16, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Don't create a link if there's nothing to link to
1 participant