Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Cannabis class #987

Merged
merged 5 commits into from
May 21, 2018
Merged

Add Faker::Cannabis class #987

merged 5 commits into from
May 21, 2018

Conversation

bpleslie
Copy link
Member

@bpleslie bpleslie commented Jul 20, 2017 •
edited
Loading

Adds Faker::Cannabis, which includes:

  • strains
  • cannabinoid abbreviations
  • cannabinoids
  • terpenes
  • medical uses
  • health benefits
  • categories
  • types
  • buzzwords
  • websites

@bpleslie bpleslie force-pushed the weedmaps/cannabis-faker branch 2 times, most recently from 834c025 to 4952e2f Compare July 20, 2017 20:47
choubacha
choubacha approved these changes Jul 20, 2017
View reviewed changes
Copy link

@choubacha choubacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

vbrazo
vbrazo requested changes May 19, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 🥇 awesome object.

Could you please rebase with master and fix the Rubocop violations?

You also need to update the changelog.md and add your name + PR.

@vbrazo vbrazo force-pushed the master branch 3 times, most recently from 6394a28 to d11bd7e Compare May 20, 2018 20:41
vbrazo
vbrazo approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. I had free time today and made the changes.

Thanks for contributing. Awesome object 👍

Pretty useful for developers in countries where cannabis is legal.

@vbrazo vbrazo changed the title [WM] Add Faker::Cannabis class Add Faker::Cannabis class May 21, 2018
@vbrazo vbrazo merged commit f5f2755 into faker-ruby:master May 21, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:25
@bpleslie bpleslie deleted the weedmaps/cannabis-faker branch August 24, 2018 00:43
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@bpleslie @vbrazo
Add Faker::Cannabis class (faker-ruby#987)
d3eaaee 
Add Faker::Cannabis class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choubacha choubacha choubacha approved these changes

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@bpleslie bpleslie

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpleslie @vbrazo @choubacha