Update FillMurray Links To Include www #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpleslie
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Looks good to me! Nice cleanup on https://github.com/stympy/faker/pull/1660/files#diff-39e7361308983b59815fc6ff150b7947R11
bpleslie
approved these changes
Jul 23, 2019
Thanks! 😊 |
|
@RaymondFallon could you fix the merge issues with our v2 branch? |
vbrazo
approved these changes
Jul 23, 2019
|
@vbrazo OK, the conflict is resolved. It is now failing CI, but it looks like that is a broader issue with |
|
True! I just made the Merging now! Thanks for fixing the urls! |
|
My pleasure, thanks for maintaining this awesome app! |
Merged
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Update FillMurray Links To Include www * Faker::Number.decimal_part should return string for now
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Update FillMurray Links To Include www * Faker::Number.decimal_part should return string for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1659 #1651
FillMurray links now need
wwwin the URL. This PR adds that and updates tests + documentation.