Fix numerical part of Dutch postcode #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dutch postcodes start at 1000, there is never a 0 on the first position,
|
And the letters can be written more consisely: (two options: two letters but never an S, |
|
In case you're wondering why: for some they refer to WWII and they wouldn't want it in their address. I am pretty sure nobody under 50 cares, but there you go. |
vbrazo
reviewed
Jan 19, 2019
|
Yeah, I saw that one coming. :)
No problem, depends if the suite is reasonably easy to setup. I will update the pull request.
… Op 19 jan. 2019 om 13:28 heeft Vitor Oliveira ***@***.***> het volgende geschreven:
@vbrazo commented on this pull request.
Thanks for contributing 👍
Could you write a test for this change?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Super easy to setup a local repo, good job! Test added. |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Fix numerical part of Dutch postcode Dutch postcodes start at 1000, there is never a 0 on the first position, * updated test for postcode with stricter regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dutch postcodes start at 1000, there is never a 0 on the first position,