Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes before release #1508

Merged
merged 8 commits into from
Jan 7, 2019
Merged

Changes before release #1508

merged 8 commits into from
Jan 7, 2019

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Jan 6, 2019

Checklist

  • Change deprecate dates to 01/2019
  • Move doc/unreleased to doc/1.9.2
  • Check the 1.8.7 deprecate methods and remove the warnings
  • Add 1.9.2.REAME.md

@vbrazo vbrazo self-assigned this Jan 6, 2019
@vbrazo vbrazo added the Chores label Jan 6, 2019
@vbrazo vbrazo merged commit a6a1cf5 into faker-ruby:master Jan 7, 2019
@vbrazo vbrazo deleted the chores/changes-before-release branch January 7, 2019 17:56
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Change deprecate dates to 01/2019

* Move docs/unreleased to docs/1.9.2

* Fix rubocop offenses

* Check the 1.8.7 deprecate methods and remove the warnings

* Revert wrong change

* Fix deprecate dates

* Fix Style/NumericLiteralPrefix cop offense

* Enable Style/NumericLiteralPrefix false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant