Add Quotes namespace #1504
Add Quotes namespace #1504
Conversation
|
I think And, although There also appears to be two deprecations in here that aren't really quotes related. Up to you and @stympy how clean that needs to be though. |
|
The |
|
You're right. I just reverted |
doc/unreleased/quotes/yoda.md
Outdated
| Available since version 1.9.0. | ||
|
|
||
| ```ruby | ||
| Faker::Quotes::Yoda.quote #=> "Use your feelings, Obi-Wan, and find him you will." |
There was a problem hiding this comment.
It feels a bit redundant to go Faker::Quotes::Yoda.quote.
Are we able to move this to Faker::Quotes.yoda while still being able to keep things like Faker::Quotes::Shakespeare?
There was a problem hiding this comment.
I agree that it feels redundant. I don't see a problem with having both Faker::Quotes.yoda and Faker::Quotes::Shakespeare, but I'm open to hearing any contrary opinions. :)
There was a problem hiding this comment.
I've just added Faker::Quote.yoda. I believe we should do the same for
Faker::Quotes::FamousLastWords.last_words
Faker::Quotes::Matz.quote
Faker::Quotes::MostInterestingManInTheWorld.quote
Faker::Quotes::Robin.quote
Faker::Quotes::SingularSiegler.quote
They should be
Faker::Quote.famous_last_words
Faker::Quote.matz
Faker::Quote.most_interesting_man_in_the_world
Faker::Quote.robin
Faker::Quote.singular_siegler
what do you think?
…er into features/add-quotes-namespace
* Add Quotes namespace * Deprecate ::Yoda * Update unreleased_README.md * Revert ::Fillmurray and ::GreekPhilosophers deprecations * Deprecate ::Shakespeare * Fix ::Yoda deprecation * Minor changes after own review * Update yoda.rb * Add quotes methods to Faker::Quote
Checklist
Faker::Shakespeare=>Faker::Quotes::ShakespeareFaker::FamousLastWords=>Faker::Quote.famous_last_wordsFaker::Matz=>Faker::Quote.matzFaker::MostInterestingManInTheWorld=>Faker::Quote.most_interesting_man_in_the_worldFaker::Robin=>Faker::Quote.robinFaker::SingularSiegler=>Faker::Quote.singular_sieglerFaker::Yoda=>Faker::Quote.yodaThis PR is related to #1318.