Add Faker::TvShows::TheExpanse #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
reviewed
Nov 30, 2018
doc/v1.9.1/the_expanse.md
Outdated
| @@ -0,0 +1,11 @@ | |||
| # Faker::TheExpanse | |||
There was a problem hiding this comment.
v1.9.1 was already released. This file should be in the doc/unreleased folder. You have to update unreleased_README.md too.
There was a problem hiding this comment.
Thanks! I've updated as requested.
vbrazo
reviewed
Dec 1, 2018
| @@ -0,0 +1,11 @@ | |||
| # Faker::TheExpanse | |||
There was a problem hiding this comment.
It should be Faker::TvShows::TheExpanse
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* add the expanse tv show data * fix typo in the_expanse.md * move .md to doc/unreleased and update unreleased README * Update the_expanse.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added data from one of my favorite shows, a Sci-Fi series called The Expanse. This is my first ever contribution to an open source project. Please let me know if this is adequate or if any changes are needed.
All tests are passing and I believe I've added all the file types needed in order to implement a new set of random data: